Fix/devtools webelementref #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Volker Buzek <[email protected]>
- restructure the protocol tests
Siolto
commented
Aug 30, 2023
vobu
approved these changes
Aug 31, 2023
Siolto
added a commit
that referenced
this pull request
Sep 7, 2023
* fix: safeguard devtools protocol stale web element ref (#524) * chore(release): 1.5.4 * fix: pass whole selector when renewing the webElementReference * test: add test for controlRetrieval with whole selector * fix: handle renewingWebElement gracefully - update internal wdi5Control properties correctly when element could not be retrieved - add test for failed webElement renewing * test: refactor stale tests and invalidate cache * fix: allControls handling with stale elements Co-authored-by: Volker Buzek <[email protected]> * fix: wdi5 v2 compatibility * fix: formatting * fix: exclude protocol tests * chore: export element_key * fix: make the stale element handling also work for the webdriver protocol - adjusted the tests to webdriver compatibility - check for webdriver stale element error message * docs: remove devtools protocol only description --------- Co-authored-by: Volker Buzek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.