Entities #405
Open
Entities #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
bigabig
commented
Jun 27, 2024
| def remove_multi(self, db: Session, *, ids: List[int]) -> List[EntityORM]: | ||
| removed = db.query(EntityORM).filter(EntityORM.id.in_(ids)).all() | ||
| db.query(EntityORM).filter(EntityORM.id.in_(ids)).delete( | ||
| synchronize_session=False |
| is_human: Optional[bool] = Field( | ||
| False, description="Whether the link was created by a human" | ||
| ) | ||
| knowledge_base_id: Optional[str] = Field("", description="Link to wikidata") |
|
|
||
|
|
||
| # Properties for merging entities/span texts | ||
| class EntityMerge(EntityBaseDTO): |
| class EntityRelease(EntityBaseDTO): | ||
| project_id: int = Field(description="Id of the current Project") | ||
| entity_ids: List[int] = Field(description="List of Entity IDs to merge") | ||
| spantext_ids: List[int] = Field(description="List of Span Text IDs to merge") |
backend/src/api/endpoints/entity.py
Outdated
| span_text_ids=[span_text_id], | ||
| ) | ||
| new_entities.append(new_entity) | ||
| db_objs = crud_entity.create_multi(db=db, create_dtos=new_entities, force=True) |
There was a problem hiding this comment.
Bitte crud_entity.release_... erstellen. und hier aufrufen.
Bei Entity Create fehlt is_human=false
| result = self.create_multi(db=db, create_dtos=[create_dto], force=force) | ||
| return result[0] if len(result) > 0 else None | ||
|
|
||
| def create_multi( |
There was a problem hiding this comment.
create multi muss mit hilfe einer hash map umgesetzt werden.
span_text_id -> entity
dann alle entities erstellen.
| ) | ||
| crud_span_text_entity_link.create_multi(db=db, create_dtos=links, force=force) | ||
| db.commit() | ||
| self.remove_all_unused_entites(db=db) |
|
span text orm muss unique text haben. |
bigabig
commented
Aug 1, 2024
| }, | ||
| {} as Record<string, EntityRead>, | ||
| ); | ||
| const projectEntitiesRows = projectEntities.data.map((entity) => { |
There was a problem hiding this comment.
add type: EnitityTableRow
from merge and release dtos
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…t aligned), changed spantexts to do as TODO intended, made it so that read_by_text returns the SpanTextORM as intended.
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.