Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update kps4_3l #46

Merged
merged 9 commits into from
Jun 21, 2024
Merged

update kps4_3l #46

merged 9 commits into from
Jun 21, 2024

Conversation

ufechner7
Copy link
Owner

add empty comments

@ufechner7 ufechner7 marked this pull request as draft June 21, 2024 16:24
@ufechner7 ufechner7 requested a review from 1-Bart-1 June 21, 2024 16:24
@ufechner7
Copy link
Owner Author

Can you please add comments and units to the new fields, and check if the short name "min_steering_line_distance" is OK for you?

@1-Bart-1 1-Bart-1 marked this pull request as ready for review June 21, 2024 16:26
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.53%. Comparing base (325036d) to head (90edf6d).
Report is 5 commits behind head on main.

Current head 90edf6d differs from pull request most recent head f168d10

Please upload reports for the commit f168d10 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #46   +/-   ##
=======================================
  Coverage   82.53%   82.53%           
=======================================
  Files           6        6           
  Lines         498      498           
=======================================
  Hits          411      411           
  Misses         87       87           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@1-Bart-1
Copy link
Collaborator

yes, I added it now

@ufechner7 ufechner7 merged commit b98a031 into main Jun 21, 2024
6 checks passed
@ufechner7 ufechner7 deleted the 3l-2 branch June 21, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants