-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove disease_type.project from all phenotype files #64
Comments
Maybe more clean up on cases.project. We have the following fields:
|
Only removing |
Let's do it here. |
@maryjgoldman Updated data in the hub. |
@yunhailuo I am confused. I am looking at your list of fields above that you asked @ayan-b to take out. Many of them are still in there but when I look at them, they are not lists. Similarly, in the old GDC data they appear to not be lists too. Can you please give an example where they are a list? Fields to investigate: |
@maryjgoldman I have only removed |
That makes a lot of sense. @ayan-b can you investigate these fields to see if there is ever a time in which they are a list? If not, then we can leave them since they are in the older GDC data as well. Fields to investigate: |
Sorry, I'm not saying they are lists. I just want to get clarifications and be sure about what to keep and what not. |
Looks great. No fields that are lists in the TCGA data |
I think we said to do this at some point but I'm still seeing this field in the files. It is a list and we don't want that. And the data in this field is already contained in the 'disease_type' field that we get from the xml files.
The text was updated successfully, but these errors were encountered: