Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR previews using wrong domain name #52

Closed
dan-hanlon opened this issue Nov 16, 2022 · 1 comment · Fixed by #73
Closed

PR previews using wrong domain name #52

dan-hanlon opened this issue Nov 16, 2022 · 1 comment · Fixed by #73
Assignees
Labels
bug Something isn't working

Comments

@dan-hanlon
Copy link
Contributor

The PR preview functionality from #12 publishes a version of the PR branch and links it in a comment. At the moment it links to the wrong domain due to a limitation in the Github action.

I've opened a PR to add the functionality in the action source code rossjrw/pr-preview-action#24 and will update here accordingly when the fix is in

@dan-hanlon dan-hanlon self-assigned this Nov 16, 2022
@dan-hanlon dan-hanlon added the bug Something isn't working label Nov 16, 2022
@docsteveharris
Copy link
Contributor

thanks. this is still a useful action. we just need to remember to change the domain name from the github.io one to the uclhal.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants