Allow empty dns #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Looks good, but I'd like to not have the formatting mixed in with this pull request, so if you can drop those commits and re-push I'll merge. |
Signed-off-by: Olivier LANIESSE <[email protected]>
Signed-off-by: Olivier LANIESSE <[email protected]>
Signed-off-by: Olivier LANIESSE <[email protected]>
Signed-off-by: Olivier LANIESSE <[email protected]>
|
@uberbrodt Done & rebased, thank you :) |
uberbrodt
approved these changes
Mar 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
Thank you for your amazing library.
This PR aims to allow caravan to use system DNS (inherited from /etc/resolv.conf) by modifying the behavior on nameservers, if we detect an empty array, we don't send any opts to inet_res.lookup.
This is very useful in our situation (we are running in docker containers where DNS aren't directly accessible from containers).
@uberbrodt Thanks by advance for your review :)