Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix xcode template installation script file copying #178

Merged
merged 1 commit into from
Dec 4, 2017
Merged

Fix xcode template installation script file copying #178

merged 1 commit into from
Dec 4, 2017

Conversation

edrew08
Copy link
Contributor

@edrew08 edrew08 commented Dec 4, 2017 •
edited
Loading

Tested with the following commands:
./install-xcode-template.sh
tooling/install-xcode-template.sh
both commands successfully copied the template files to Xcode/Templates/File Templates/RIBs.

@edrew08 edrew08 mentioned this pull request Dec 4, 2017
Closed
@artman artman self-requested a review December 4, 2017 17:18
artman
artman approved these changes Dec 4, 2017
View reviewed changes
Copy link
Contributor

@artman artman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@artman artman merged commit dba0ee7 into uber:master Dec 4, 2017
@edrew08 edrew08 deleted the install-script branch December 5, 2017 15:37
CosmicYogi pushed a commit to CosmicYogi/RIBs that referenced this pull request Jan 8, 2020
@edrew08 @artman
Fix xcode template installation script file copying (uber#178)
9fa538e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artman artman artman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edrew08 @artman