-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop vendoring cloudpickle #62
Comments
I agree with this. When we first started doing things with cloudpickle, it was a bit more niche, but it has since become much more widely used. I think we can rely on it to be available from standard sources, if the user wants, and so we can probably stop including our own copy. Very good, thank you. |
I'll submit a PR for this after #61 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Just a thought - since there are now regular fixes for new Python versions upstream (see https://github.com/cloudpipe/cloudpickle/commits/master) maybe we should stop trying to vendor our own version and always be out of date. The rate of Python internal changes does seem to be increasing...
Both conda-forge and Ubuntu provide packages for
cloudpickle
. Of course you can alsopip install
it so not really hard for a user to obtain.How about we remove it from
rios
and expect the user to have it installed if they are using theparallel
functionality (users who aren't will see no difference)?I can modify the conda-forge recipe to install it when
rios
is installed.The text was updated successfully, but these errors were encountered: