fix: Property metadata override does not work when extending an entity class #10896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titovb
force-pushed
the
master
branch
2 times, most recently
from
c60495f
to
baa8f39
Compare
fix documentation
fix & add tests
titovb
commented
May 20, 2024
| ) | ||
| newArray.push(item) | ||
| const uniqueArray: T[] = [] | ||
| const targets = Array.isArray(target) ? [...target].reverse() : [target] |
There was a problem hiding this comment.
The targets are added in the order ChildChild < Child < Base. Therefore, we need to reverse it to apply the parent columns first and override them if they were overridden by the child.
| @@ -307,7 +307,6 @@ const ASchema = new EntitySchema<A>({ | |||
| // specified on the 'discriminatorValue' property | |||
| discriminatorValue: "my-custom-discriminator-value-for-A", | |||
| columns: { | |||
| ...BaseSchema.options.columns, | |||
There was a problem hiding this comment.
@pleerock @AlexMesser Could you verify these changes to the documentation and tests?
Correct me if I'm wrong, but the addition of BaseSchema columns is not needed because STI inheritance ensures the addition of BaseSchema columns using metadata from BaseSchema, so we don't need to override them.
titovb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Fixes #10895
Pull-Request Checklist
masterbranchnpm run formatto apply prettier formattingnpm run testpasses with this changeFixes #0000