Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compatibility with babel 5 #13

Closed
carakan opened this issue Jun 19, 2017 · 5 comments
Closed

compatibility with babel 5 #13

carakan opened this issue Jun 19, 2017 · 5 comments

Comments

@carakan
Copy link

carakan commented Jun 19, 2017

I'm working on a project with ember 2.10 that have a dependency with ember-cli-babel 5.x, right now in development has running fine, but the test is totally broken:

⠋ BuildingCannot read property 'babel' of undefined
TypeError: Cannot read property 'babel' of undefined
    at Class._setupBabelOptions (...node_modules/ember-attacher/index.js:36:40)
    at Class.included (..../node_modules/ember-attacher/index.js:16:10)

is possible to add compatibility for babel 5?
@carakan carakan mentioned this issue Jun 19, 2017
Closed
@kybishop
Copy link
Collaborator

kybishop commented Jun 20, 2017 •
edited
Loading

Hey @carakan, thanks for filing an issue!

I'm going to investigate why this.options is undefined to make sure we understand the root cause.

I'm having trouble reproducing the bug locally with ember-cli-babel v5.2.4. What version of babel 5 are you using?

@carakan
Copy link
Author

carakan commented Jun 20, 2017

thank you for your response @kybishop, not sure if there is the error or is an error on ember upgrade, because we upgraded from 2.6 to 2.10.

@kybishop
Copy link
Collaborator

kybishop commented Jun 21, 2017 •
edited
Loading

I'm up in the mountains until Thursday, but will see if I can reproduce with a plain ember 2.10 app once back to the real world 😉. If you're able to isolate the cause before then, let me know!

I'd like to hold off on accepting the PR until we know the cause, just to make sure it is not from a non-standard configuration vs an actual bug

@kybishop
Copy link
Collaborator

kybishop commented Jul 8, 2017

Sorry I let this hang! I have reproduced the bug and discovered another in the process. Working on a fix now.

@kybishop
Copy link
Collaborator

kybishop commented Jul 8, 2017

@carakan this should be fixed by #20 and #19. Let me know if the error persists! Releasing these fixes now in ember-attacher v0.5.1

@kybishop kybishop closed this as completed Jul 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix error when use babel 5 carakan/ember-attacher
2 participants
@carakan @kybishop