Skip to content
This repository has been archived by the owner on Apr 24, 2023. It is now read-only.

Avoid round trips from job-entities -> uuids -> job-entities in generating /list API endpoint. #790

Open
scrosby opened this issue Mar 28, 2018 · 3 comments
Assignees

Comments

@scrosby
Copy link
Member

scrosby commented Mar 28, 2018

In cook.mesos.api/list-jobs, we lookup jobs by entity, then map them to UUID.
Then in https://github.com/twosigma/Cook/blob/master/scheduler/src/cook/mesos/api.clj#L2164, we call cook.mesos.api/fetch-job-map that maps the UUID's back into job-entities. Lets not do this round trip.

@scrosby scrosby self-assigned this Mar 28, 2018
@dposada
Copy link
Contributor

dposada commented Mar 28, 2018

Is this a duplicate of issue #617 ?

@DaoWen
Copy link
Contributor

DaoWen commented Mar 31, 2018

I'm closing this as a duplicate of #617—but I reported #617, and I wholeheartedly agree that we should fix this!

@scrosby
Copy link
Member Author

scrosby commented May 31, 2018

Its related to #617 in that I'm avoiding round-tripping to and from UUID. But its not a duplicate. Fixing this does not involve any changes to what goes into the liberator context --- the dataflow is via function arguments.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants