-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Module Pattern (replace Twig global) #622
Milestone
Comments
God is an anti-pattern 😈 Likely legacy, for allowing acting on a global through the web browser. Packages like Browserify and webpack can fix that pattern for us. Would be good to switch to ES6 modules across all the files. |
There were mentions of a 2.0.0 release in other topics and PRs. The 2.0.0 release should breakup the global object into modules as part of the changes, would you agree? |
We can wait on a 2.x for this, yes. |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@RobLoach
Each of the files simply serve to build up the
Twig
god object.What was the rationale behind this design? God objects are considered to be an anti-pattern.
The text was updated successfully, but these errors were encountered: