Remove the heart icon button to add the view as a favorite from the top bar #8769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehconitin
commented
Nov 26, 2024
| isFavoriteFolderEnabled && ( | ||
| <MenuItem | ||
| LeftIcon={IconHeart} | ||
| text={'Favorite picker'} |
There was a problem hiding this comment.
@Bonapara I was not sure what to call this :), for now I have named the menu item Favorite picker
|
Hey @ehconitin! I cannot see the add/remove from favorites button in the view switcher 🤔 CleanShot.2024-11-27.at.10.11.16.mp4 |
|
@Bonapara |
|
@ehconitin we would like the view to be added directly to the favorite root level when we press "Add to Favorites". When a view is already part of favorites, the CTA should be called "Manage Favorite". Also, could you display the "Favorite" menu to the right of the |
|
Functional comments:
|
martmull
reviewed
Nov 29, 2024
Comment on lines
+107
to
+133
| dropdownComponents={(() => { | ||
| switch (viewPickerMode) { | ||
| case 'list': | ||
| return <ViewPickerListContent />; | ||
| case 'favorite-folders-picker': | ||
| return ( | ||
| isFavoriteFolderEnabled && <ViewPickerFavoriteFoldersDropdown /> | ||
| ); | ||
| case 'create-empty': | ||
| case 'create-from-current': | ||
| return ( | ||
| <> | ||
| <ViewPickerContentCreateMode /> | ||
| <ViewPickerContentEffect /> | ||
| </> | ||
| ); | ||
| case 'edit': | ||
| return ( | ||
| <> | ||
| <ViewPickerContentEditMode /> | ||
| <ViewPickerContentEffect /> | ||
| </> | ||
| ); | ||
| default: | ||
| return null; | ||
| } | ||
| })()} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8546
@Bonapara please check the behaviour, if this is what you were looking for! ;)