Fix Error field type rich text #8739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Summary
Added temporary support for filtering rich text fields by treating them as regular text fields, addressing errors that occurred when filtering notes and other rich text content.
- Added RichText case in
isRecordMatchingFilter.tsthat usesisMatchingStringFilteras a temporary solution - Added TODO comment indicating a more comprehensive solution for rich text filtering is planned for Q4'24 when it becomes a composite field
- Fixes issue Error field type rich text #8445 where rich text fields were causing filtering errors
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Weiko
pushed a commit
that referenced
this pull request
Nov 26, 2024
fix #8445 It seems linked to commandBar search where we filter tasks/notes by body with ilike.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #8445
It seems linked to commandBar search where we filter tasks/notes by body with ilike.