Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scroll dropdown listing in hidden fields #8738

Merged

Conversation

harshrajeevsingh
Copy link
Contributor

Fixes: #8716

Screencast.from.2024-11-25.22-06-24.webm

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This change adds a ScrollWrapper component to the dropdown menu in RecordTableHeaderPlusButtonContent to enable scrolling when there are numerous hidden fields in the dropdown list.

  • Added ScrollWrapper in /packages/twenty-front/src/modules/object-record/record-table/record-table-header/components/RecordTableHeaderPlusButtonContent.tsx to fix dropdown overflow issues
  • Ensures dropdown content remains within viewport while allowing scrolling for long lists of hidden fields

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@lucasbordeau lucasbordeau self-assigned this Nov 26, 2024
@lucasbordeau
Copy link
Contributor

lucasbordeau commented Nov 27, 2024

The problem has been fixed for all dropdowns.

I changed the size middleware so it calls fluchSync because modifying the DOM directly was preventing other components from detecting the change of height.

Since it is called only in case of resizing the window or other components, it's ok.

@lucasbordeau lucasbordeau merged commit 3ad1113 into twentyhq:main Nov 27, 2024
17 checks passed
Copy link

Thanks @harshrajeevsingh for your contribution!
This marks your 21st PR on the repo. You're top 2% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scroll broken on DropDown listing hidden fields Column
2 participants