Fix missing timeline activity events #8459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Summary
This PR fixes missing timeline activity events by restoring the proper handling of linked event names and improving the event transformation logic.
- Renamed
TransformedEventtype toTimelineActivitywith requirednamefield in/packages/twenty-server/src/modules/timeline/services/timeline-activity.service.ts - Fixed event name propagation by ensuring
linked-{eventName}format is preserved for linked activities - Renamed methods for clarity (e.g.
processActivity->computeActivities) to better reflect their purpose - Added proper handling of linked records through
linkedRecordCachedName,linkedRecordId, andlinkedObjectMetadataIdfields
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+79
to
+80
| if (linkedTimelineActivities && linkedTimelineActivities?.length > 0) | ||
| return [...linkedTimelineActivities, { ...event, name: eventName }]; |
There was a problem hiding this comment.
logic: redundant check - linkedTimelineActivities is already checked for truthiness
charlesBochet
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug introduced in #8193
Taking into account linked event name
linked-{eventName}as before issueBefore
linked-createdandlinked-updatedactivity targets were not created intimelineActivitytableAfter
linked-createdandlinked-updatedactivity targets are created intimelineActivitytable