Add CI timeouts and enable playwright #8405
Conversation
There was a problem hiding this comment.
PR Summary
This PR adds timeouts to various CI/CD workflows and enables Playwright testing, with significant changes to workflow execution times and job structures across multiple GitHub Actions files.
- Deployment workflows (cd-deploy-main.yaml, cd-deploy-tag.yaml) have concerningly short 3-minute timeouts that may cause premature terminations
- Front-end workflow (ci-front.yaml) reduces timeout from 60 to 30 minutes while adding Playwright tests, potentially causing timing issues
- Chrome extension workflow consolidates jobs and adds file change detection with a possible condition bug using 'changed' instead of 'any_changed'
- Docker Compose workflow adds server health monitoring with a 300-second timeout and change-based execution
- Website CI workflow uses hardcoded database credentials in plain text, presenting a security risk
12 file(s) reviewed, 5 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -1,4 +1,5 @@ | |||
| name: CD deploy main | |||
| timeout-minutes: 3 | |||
There was a problem hiding this comment.
logic: 3 minutes is likely too short for a deployment workflow. Consider increasing to at least 15-30 minutes to match other workflow timeouts and ensure successful deployments.
There was a problem hiding this comment.
sentry/[email protected]":
version "5.15.4"
resolved "https://registry.yarnpkg.com/@sentry/utils/-/utils-5.15.4.tgz#02865ab3c9b745656cea0ab183767ec26c96f6e6"
integrity sha512-lO8SLBjrUDGADl0LOkd55R5oL510d/1SaI08/IBHZCxCUwI4TiYo5EPECq8mrj3XGfgCyq9osw33bymRlIDuSQ==
dependencies:
"@sentry/types" "5.15.4"
tslib "^1.9.3"
| @@ -1,4 +1,5 @@ | |||
| name: CD deploy tag | |||
| timeout-minutes: 3 | |||
There was a problem hiding this comment.
logic: 3 minutes is likely too short for a deployment workflow. Consider increasing to 15-30 minutes to allow for potential delays in infrastructure provisioning and deployment steps.
| @@ -1,4 +1,5 @@ | |||
| name: CI Front | |||
| timeout-minutes: 30 | |||
There was a problem hiding this comment.
logic: Reducing timeout from 60 to 30 minutes while adding Playwright tests may cause timeouts. Consider keeping 60 minutes or testing thoroughly to ensure 30 minutes is sufficient.
| @@ -1,4 +1,5 @@ | |||
| name: CI Utils | |||
| timeout-minutes: 3 | |||
There was a problem hiding this comment.
style: 3 minutes may be too short for Danger.js on large PRs. Consider increasing to 5-10 minutes to avoid timeouts.
| @@ -1,4 +1,5 @@ | |||
| name: CI Website | |||
| timeout-minutes: 10 | |||
There was a problem hiding this comment.
style: 10 minutes may be too short for migrations + build. Consider increasing to 15-20 minutes to prevent timeouts during heavy builds.
No description provided.