Unselect record table records on table body click #8306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Summary
Refactored table record unselection handling by consolidating click-outside detection and keyboard shortcuts into a dedicated component.
- Renamed
RecordTableInternalEffecttoRecordTableBodyUnselectEffectfor clearer responsibility - Added
tableBodyRefinRecordTable.tsxto track clicks outside table area - Fixed type mismatch between
HTMLTableElementandHTMLDivElementfor table body ref - Simplified focus management by removing
recordTableIdparameter fromuseLeaveTableFocus
3 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -32,6 +34,8 @@ export const RecordTable = ({ | |||
| objectNameSingular, | |||
| onColumnsChange, | |||
| }: RecordTableProps) => { | |||
| const tableBodyRef = useRef<HTMLTableElement>(null); | |||
There was a problem hiding this comment.
logic: Type mismatch between tableBodyRef (HTMLTableElement) and RecordTableBodyUnselectEffect props (HTMLDivElement)
Comment on lines
73
to
86
| <StyledTableInternalContainer ref={tableRef}> | ||
| <RecordTable | ||
| viewBarId={viewBarId} | ||
| recordTableId={recordTableId} | ||
| objectNameSingular={objectNameSingular} | ||
| onColumnsChange={handleColumnsChange} | ||
| /> | ||
| <DragSelect | ||
| dragSelectable={tableBodyRef} | ||
| dragSelectable={tableRef} | ||
| onDragSelectionStart={() => { | ||
| resetTableRowSelection(); | ||
| }} | ||
| onDragSelectionChange={setRowSelected} | ||
| /> |
There was a problem hiding this comment.
logic: DragSelect is now positioned inside StyledTableInternalContainer which could affect its behavior if the container has overflow constraints
bosiraphael
reviewed
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have previously fixed the unselection of table records on click outside. However, the ref was mispositioned as it selected the full height table. In the case of low record numbers, we also want the unselection to happen on table body click