Fix background mock #6463
Fix background mock #6463
Conversation
There was a problem hiding this comment.
PR Summary
The pull request focuses on updating type definitions and enhancing mock data for the sign-in background module.
- Updated
typeproperty fromFieldMetadataType.LinktoFieldMetadataType.Linksinpackages/twenty-front/src/modules/sign-in-background-mock/constants/SignInBackgroundMockColumnDefinitions.ts. - Added
secondaryLinksand new fields (addressCountry,addressLat,addressLng,__typename) inpackages/twenty-front/src/modules/sign-in-background-mock/constants/SignInBackgroundMockCompanies.ts. - Ensure all related components and functions handle the new
FieldMetadataType.Linkstype correctly. - Verify consistency of mock data updates across all related files and tests.
2 file(s) reviewed, 6 comment(s)
Edit PR Review Bot Settings
| @@ -180,7 +180,7 @@ export const SIGN_IN_BACKGROUND_MOCK_COLUMN_DEFINITIONS = ( | |||
| fieldMetadataId: '20202020-a61d-4b78-b998-3fd88b4f73a1', | |||
| label: 'Linkedin', | |||
| size: 100, | |||
| type: FieldMetadataType.Link, | |||
| type: FieldMetadataType.Links, | |||
There was a problem hiding this comment.
check: Verify that the change from Link to Links does not affect any existing data or functionality.
| @@ -214,7 +214,7 @@ export const SIGN_IN_BACKGROUND_MOCK_COLUMN_DEFINITIONS = ( | |||
| fieldMetadataId: '20202020-46e3-479a-b8f4-77137c74daa6', | |||
| label: 'X', | |||
| size: 100, | |||
| type: FieldMetadataType.Link, | |||
| type: FieldMetadataType.Links, | |||
There was a problem hiding this comment.
style: Check if any logic specifically checks for FieldMetadataType.Link and update it to handle FieldMetadataType.Links.
| domainName: { | ||
| primaryLinkUrl: 'qonto.com', | ||
| primaryLinkLabel: '', | ||
| secondaryLinks: [], | ||
| __typename: 'Links', |
There was a problem hiding this comment.
style: Ensure secondaryLinks is correctly handled in all related components and queries.
| addressState: null, | ||
| addressPostcode: '75009', | ||
| addressCountry: 'France', | ||
| addressCity: 'Paris', | ||
| addressLat: null, | ||
| addressLng: null, | ||
| __typename: 'Address', |
There was a problem hiding this comment.
check: Verify that the new address fields (addressCountry, addressLat, addressLng) are correctly populated and used in the application.
| primaryLinkLabel: 'asd', | ||
| primaryLinkUrl: 'asd.com', | ||
| secondaryLinks: null, | ||
| __typename: 'Links', |
There was a problem hiding this comment.
style: Check if secondaryLinks being null is handled gracefully in the UI and backend.
| primaryLinkLabel: null, | ||
| primaryLinkUrl: null, | ||
| secondaryLinks: null, | ||
| __typename: 'Links', |
There was a problem hiding this comment.
style: Ensure that secondaryLinks being null does not cause any issues in GraphQL queries or mutations.
## Before <img width="1284" alt="Screenshot 2024-07-30 at 18 24 04" src="https://github.com/user-attachments/assets/3c8d2ee9-daa0-4b32-ac90-7124252bc79c"> ## After <img width="1317" alt="Screenshot 2024-07-30 at 18 23 57" src="https://github.com/user-attachments/assets/5dd36510-cf42-4698-a395-8435e6552810">
Before
After