Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When exporting a kanban we should export the kanban's main field #6444

Merged
merged 4 commits into from
Aug 9, 2024

Conversation

gitstart-app[bot]
Copy link
Contributor

@gitstart-app gitstart-app bot commented Jul 29, 2024

This PR was created by GitStart to address the requirements from this ticket: TWNTY-6046.
This ticket was imported from: TWNTY-6046


Description

  • We are getting the kanbanFieldMetadataNameState , get the column data, and if there is data and the use is on the Kanban view we add the data to the result

Refs

#6046

Demo

https://jam.dev/c/96f16211-40e4-4b49-a6f5-88f0692fb47a

Fixes #6046

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR enhances the Kanban export functionality by including the Kanban's main field in the CSV export.

  • RecordIndexOptionsDropdownContent.tsx: Added viewType prop to handle different view types (Kanban and Table) for export.
  • useExportTableData.ts: Introduced viewType parameter to include the Kanban's main field in the export.
  • useTableData.ts: Added logic to fetch and append the Kanban field to the export data when in Kanban view.

3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@gitstart-twenty
Copy link
Contributor

There are tests failing that were not failing when we sent the initial changes, what failed was only the coverage as we added a new feature. All tests passed before, the current failures are not related to PR

@gitstart-twenty gitstart-twenty marked this pull request as ready for review August 8, 2024 17:10
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

The latest changes focus on enhancing the Kanban export functionality by ensuring the main field used to build Kanban columns is included in the export data.

  • packages/twenty-front/src/modules/object-record/record-board/record-board-card/components/RecordBoardCard.tsx: Added hoverable property to Checkbox and updated FieldContext.Provider to use recordId instead of entityId.
  • packages/twenty-front/src/modules/object-record/record-board/record-board-column/components/RecordBoardColumnHeader.tsx: Introduced weight prop to Tag component based on columnDefinition.type.
  • packages/twenty-front/src/modules/object-record/record-field/components/FieldDisplay.tsx: Added support for RichTextFieldDisplay and ActorFieldDisplay.
  • packages/twenty-front/src/modules/object-record/record-field/hooks/useInitDraftValueV2.ts: Included FIELD_NOT_OVERWRITTEN_AT_DRAFT constant and replaced entityId with recordId.
  • packages/twenty-front/src/modules/object-record/record-field/hooks/usePersistField.ts: Replaced entityId with recordId for consistency.

298 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link
Member

@FelixMalfait FelixMalfait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks

@FelixMalfait FelixMalfait merged commit a2a5ab4 into main Aug 9, 2024
9 of 10 checks passed
@FelixMalfait FelixMalfait deleted the TWNTY-6046 branch August 9, 2024 08:23
Copy link

github-actions bot commented Aug 9, 2024

Fails
🚫

node failed.

Log

�[31mError: �[39m SyntaxError: Unexpected end of JSON input
    at JSON.parse (<anonymous>)
�[90m    at parseJSONFromBytes (node:internal/deps/undici/undici:5584:19)�[39m
�[90m    at successSteps (node:internal/deps/undici/undici:5555:27)�[39m
�[90m    at fullyReadBody (node:internal/deps/undici/undici:1665:9)�[39m
�[90m    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)�[39m
�[90m    at async specConsumeBody (node:internal/deps/undici/undici:5564:7)�[39m
danger-results:https://tmp/danger-results-8cdae3ec.json

Generated by 🚫 dangerJS against 6b8e1a6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When exporting a kanban we should export the kanban's main field
2 participants