Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display of boolean fields in timeline activities #6361

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

ijreilly
Copy link
Collaborator

before
Capture d’écran 2024-07-22 à 11 29 59

after
Capture d’écran 2024-07-22 à 11 31 07

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

The pull request improves the display of boolean fields in timeline activities by utilizing a utility function for better code consistency.

  • Modified packages/twenty-front/src/modules/activities/timelineActivities/rows/main-object/components/EventFieldDiffValueEffect.tsx to use isDefined from twenty-ui for null/undefined checks.
  • Enhances code readability and consistency without introducing functional changes.
  • No security issues or potential pitfalls identified with this update.

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@thomtrp thomtrp merged commit 14fcd5f into main Jul 22, 2024
13 checks passed
@thomtrp thomtrp deleted the fix-display-boolean-field-timeline-activity branch July 22, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants