Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined state from react-router-dom. #6293

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

lucasbordeau
Copy link
Contributor

Fix state not well typed from react-router-dom, it can be undefined and we should check for that.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Added nullish coalescing operator to handle potentially undefined state from react-router-dom
  • Ensured safe access to the cursor property to prevent runtime errors

File: packages/twenty-front/src/modules/object-record/record-show/hooks/useRecordShowPagePagination.ts

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@ijreilly ijreilly merged commit 8833a38 into main Jul 16, 2024
7 of 10 checks passed
@ijreilly ijreilly deleted the fix/show-page-without-view branch July 16, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants