-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
truncate the string if overlow the text #6166
truncate the string if overlow the text #6166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
- Truncate full name in
packages/twenty-front/src/modules/object-record/record-field/meta-types/display/components/FullNameFieldDisplay.tsx
based on device type (15 chars for mobile, 20 for desktop) - Adjust
max-width
inpackages/twenty-front/src/modules/ui/field/display/components/EllipsisDisplay.tsx
to handle text overflow properly
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
- No major changes found since last review.
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Hey Roberto, I think it should adapt to the parent container's size to avoid harcoding any value indeed. Also we want to leverage CSS' native ellipsis feature whenever we can instead of using Javascript. Can you try it this way? There are already examples of Ellipsis with a tooltip component in the codebase |
@FelixMalfait oh ok Felix, cool, I'll work on this as soon as possible, I think tomorrow I'll have some time :) |
Thanks @RobertoSimonini1 for your contribution! |
This PR aims to fix #6102
I think we should dicuss a bit about how we should manage the lenght and set the variables globally
Edit :
@RobertoSimonini1 I used this PR to fix various problems that were left unsolved :