Remove the right drawer full page button for emails and calendar events #8612
Labels
good first issue
Good for newcomers
scope: front
Issues that are affecting the frontend side only
size: short
type: chore
Comments
|
I will take a look |
|
Hello @bosiraphael, I’d like to work on this issue. Could you please assign it to me? Thank you! |
Weiko
added a commit
that referenced
this issue
Nov 20, 2024
) ### Overview This pull request addresses issue #8612 by ensuring the "Expand to Full Page" button does not appear on the Email and Calendar pages in the right drawer. ### Changes Made - Added conditions in the `RightDrawerTopBar` component to prevent the `RightDrawerTopBarExpandButton` from rendering on: - Email pages (`RightDrawerPages.ViewEmailThread`) - Calendar pages (`RightDrawerPages.ViewCalendarEvent`) - Verified that the button still renders correctly on other pages, such as Record pages. ### Testing Since I couldn't run the project locally, I was unable to confirm the changes in a running environment. However, the logic has been carefully updated to ensure the button is conditionally hidden based on the current `rightDrawerPage` state. ### Additional Notes Please let me know if further adjustments are needed or if there are any issues during testing. Thank you for reviewing this PR! --------- Co-authored-by: Weiko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Scope & Context
The full page is implemented only for records for the moment, it redirects to the record showpage. There is no implementation of the full page for the calendar events and the emails.
Technical inputs
Remove the right drawer full page button for emails and calendar events.
The text was updated successfully, but these errors were encountered: