Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintaining this list in AdGuard format in a fork #3

Open
jarelllama opened this issue Apr 21, 2024 · 2 comments
Open

Maintaining this list in AdGuard format in a fork #3

jarelllama opened this issue Apr 21, 2024 · 2 comments

Comments

@jarelllama
Copy link

jarelllama commented Apr 21, 2024

Hi, I appreciate the creation and idea of this blocklist. I was one of the first few people to recommend this list to Hagezi. I have forked this blocklist and am maintaining it with my own code to implement the ABP syntax to make use of wildcard matching in Pihole and AdGuard. I also automatically remove dead domains and redundant rules.

I initially just wanted to include the emerging-phishing rules in Jarelllama's Scam Blocklist but figured I might as well maintain the malware rules too.

The fork can be found here: https://github.com/jarelllama/emerging-threats-pihole

I have kept the original licenses in the repo and blocklist. If you dislike/disagree with any part of the fork, please do let me know.

@jarelllama jarelllama changed the title Mainting this list on a fork Maintaining this list on a fork Apr 21, 2024
@jarelllama jarelllama changed the title Maintaining this list on a fork Maintaining this list in AdGuard format in a fork Apr 21, 2024
@jarelllama jarelllama reopened this Apr 21, 2024
@tweedge
Copy link
Owner

tweedge commented Apr 21, 2024

Great to see!! Mind if I link to your repo in the README as well?

@jarelllama
Copy link
Author

jarelllama commented Apr 21, 2024

Thanks for the positive response! Go ahead.

Also I might as well explain some of the changes:

  • Dead domains and redundant domains are removed automatically
  • Rulesets with zero extracted domains are removed
  • Added a whitelist filter
  • Updated which keyword phrases to check for:
# Ignore rules with specific payload keywords. See here:
# https://docs.suricata.io/en/suricata-6.0.0/rules/payload-keywords.html
# Note 'endswith' is accepted as those rules tend to be wildcard matches of root domains.
# Ignore IP addresses
# Remove leading periods ('endswith' rules)
# Convert to lower case
# Remove whitelisted domains
mawk '!/^#/ && /dns[\.|_]query/ && !/content:!/ && !/startswith/ &&
    !/offset/ && !/distance/ && !/within/ && !/pcre/'
...

I had to rewrite your script from scratch in Bash, I hope you don't mind that. I've kept most of your README intact. Please do have a look and let me know your thoughts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants