Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precompiled dark version #28424

Closed
fuzzy76 opened this issue Mar 7, 2019 · 5 comments · Fixed by #35857
Closed

Precompiled dark version #28424

fuzzy76 opened this issue Mar 7, 2019 · 5 comments · Fixed by #35857

Comments

@fuzzy76
Copy link

fuzzy76 commented Mar 7, 2019

Since there are several elements (like the hamburger menu) that won't work with the default settings on a "light text on dark background" scenario without recompiling, would it be possible to offer a precompiled dark version (ie colors inverted)?

@ysds
Copy link
Member

ysds commented Mar 7, 2019

If you mean windows high-contrast mode, this might be duplicate of #21269.

@fuzzy76
Copy link
Author

fuzzy76 commented Mar 7, 2019

No, I was talking about website design colors. If you create a site with dark background and light text, every element that has SVG background images set becomes invisible / impossible to see.

@patrickhlauke
Copy link
Member

i think this would be solved more fundamentally by having SVGs use currentColor in their styles. however, that doesn't work with background SVGs, and would require foreground <svg> (as noted in #21269 )

@patrickhlauke
Copy link
Member

so i think i'd rather spend energy on the fundamental fix, rather than a separate precompiled dark version, tbh

@mdo
Copy link
Member

mdo commented Mar 8, 2019

We won't be providing a prebuilt dark version (although I am messing around with dark mode for our docs with a handful of overrides), but v5 could see some improvements to how we handle SVGs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants