Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Quality Measures Source and Normalized Code Pulls #521

Merged
merged 12 commits into from
Jul 1, 2024

Conversation

utsavpaudel
Copy link
Contributor

Describe your changes

  • Quality Measure mart's denominator model's age field documentation updated in yaml, according to implementation and measure document.
  • Pulls normalized code and code type, coalescing with source code and code type as well to resolve diabetes eye exam should pull from normalized codes also #514
  • Updated CBE0055 denominator filename to match naming convention.
  • Refactored formatting to match style guide.

How has this been tested?

dbt build

Reviewer focus

Please summarize the specific items you’d like the reviewer(s) to look into.

Checklist before requesting a review

  • I have added at least one Github label to this PR (bug, enhancement, breaking change,...)
  • My code follows style guidelines
  • (New models) YAML files are categorized by sub folder and models listed in alphabetical order
  • (New models) I have added a config to each new model to enable it for claims and/or clinical data
  • (New models) I have added the variable tuva_last_run to the final output
  • (Optional) I have recorded a Loom to explain this PR

Package release checklist

  • I have updated dbt docs
  • I have updated the version number in the dbt_project.yml

(Optional) Gif of how this PR makes you feel

Loom link

Copy link

github-actions bot commented Jul 1, 2024

Workflow has finished with the following statuses:

  • Snowflake: success
  • Snowflake: success
  • Snowflake: success
  • Redshift: success
  • Redshift: success
  • Redshift: success
  • BigQuery: success
  • BigQuery: success
  • BigQuery: success

Copy link
Member

@sarah-tuva sarah-tuva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @utsavpaudel, thanks for submitting this PR to clean up and standardize some of the code. I just see one issue that needs to be fixed. I will commit this change so we can finish testing and get it merged in.

…in_a1c/quality_measures__int_nqf0059_denominator.sql
Copy link

github-actions bot commented Jul 1, 2024

Workflow has finished with the following statuses:

  • Snowflake: success
  • Snowflake: success
  • Snowflake: success
  • Redshift: success
  • Redshift: success
  • Redshift: success
  • BigQuery: success
  • BigQuery: success
  • BigQuery: success

@sarah-tuva
Copy link
Member

Internal CI test jobs ran automatically after I pushed a change. I ran the outside contributor jobs again, and they all succeeded.

@sarah-tuva sarah-tuva merged commit 13fd821 into tuva-health:main Jul 1, 2024
2 of 5 checks passed
@sarah-tuva sarah-tuva deleted the qm_bugfix branch July 1, 2024 22:30
@thutuva thutuva added the bug Something isn't working label Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

diabetes eye exam should pull from normalized codes also
3 participants