Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

各botのディレクトリ階層を分けたい #853

Open
Szkieletor37 opened this issue Sep 22, 2023 · 5 comments
Open

各botのディレクトリ階層を分けたい #853

Szkieletor37 opened this issue Sep 22, 2023 · 5 comments
Assignees
Labels
enhancement suggestion suggestion or new feature/bot

Comments

@Szkieletor37
Copy link
Contributor

いま GitHub を見ながら、たくさん root にフォルダがあるのにどれが bot 関係でどれが lib みたいなやつなのかわかりづらくて、bot 関連を bot/ahokusa みたいに1段階深くしたい……したくないですか?(そうでもないのかな)

しかし変更がどういう箇所に及ぶかわからないのであった(パスが変わると、どこに問題が起きるんだろ)

@hakatashi
Copy link
Member

良いと思う ディレクトリ名は bots に1票

@hideo54
Copy link
Member

hideo54 commented Sep 23, 2023

賛成です。ルートにファイル多すぎるよなあとは前々から思うておりました

@Szkieletor37
Copy link
Contributor Author

Szkieletor37 commented Sep 23, 2023

話逸れますが設定ファイル系 ( jest.config.js とか)って全部root直下に置かないといけないんですか?(話が逸れるので、別のissueの方がいいのかな)

@Szkieletor37 Szkieletor37 self-assigned this Sep 23, 2023
@Szkieletor37 Szkieletor37 added enhancement suggestion suggestion or new feature/bot labels Sep 23, 2023
@Szkieletor37
Copy link
Contributor Author

.
├── api
├── bin
├── bots
├── functions
├── lib
├── __mocks__
├── node_modules
├── oauth
├── Cargo.lock
├── Cargo.toml
├── CODEOWNERS
├── ecosystem.config.js
├── firebase.json
├── firestore.indexes.json
├── firestore.rules
├── globals.d.ts
├── index.ts
├── jest.config.js
├── LICENSE
├── package.json
├── package-lock.json
├── README.md
├── tokens.sqlite3
└── tsconfig.json

いま手元でこうしましたがこれでどうですか ( oauth までがディレクトリ)( oauth はbotなのか?)

@Szkieletor37
Copy link
Contributor Author

api もbotかな?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement suggestion suggestion or new feature/bot
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants