Replace pillow's deprecated textsize, add zooming support #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use textbbox instead of the deprecated textsize method
Take into account font descent when computing the size of the text bbox
Bring back accidentally deleted lines
|
@jbruned Thank you so much for the PR!! Especially for the zooming support! I'll review it asap. |
Sure! It's a pretty basic implementation but I found it useful for my use case so I opened a PR. Thank you for the tool as well! |
wangf1978
approved these changes
Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getbboxsizeinstead of the deprecatedtextsize[critical fix, closes Issue: PIL deprecated the textsize() method in 10.0.0 #74]image_root, if available, when not provided via command line [feature]Ctrl++orCtrl+-[feature, closes Large image support #53]