Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collapse taxonomy/combine outputs features #9

Open
microbemarsh opened this issue Mar 27, 2024 · 3 comments
Open

Add collapse taxonomy/combine outputs features #9

microbemarsh opened this issue Mar 27, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@microbemarsh
Copy link
Collaborator

Possible Enhancement

I know you're prob just a little busy but for interpreting the results at higher taxonomic levels down the line these might be useful to add:

https://github.com/treangenlab/emu?tab=readme-ov-file#collapse-taxonomy

https://github.com/treangenlab/emu?tab=readme-ov-file#combine-outputs

@nsapoval
Copy link
Collaborator

I believe the collapse_ranks function (lines 756-776) already does that. The corresponding CLI flag is -r, --rank and it defaults to species. However, you should be able to specify genus or any other rank that is part of the full output as an option.

Let me know if this works or if you encounter any bugs while trying it out. In the meantime, I'll work on writing the usage section of README to cover all of the flags currently supported.

@microbemarsh
Copy link
Collaborator Author

microbemarsh commented Mar 27, 2024

Ah sorry, I see now. I guess just a combine-outputs function would be useful too if running multiple samples together but users could always do that part themselves

@nsapoval nsapoval added the enhancement New feature or request label Apr 1, 2024
@nsapoval
Copy link
Collaborator

nsapoval commented Apr 1, 2024

Ah I see what you mean. I'll work on this soon.

@nsapoval nsapoval self-assigned this Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants