Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send_remote_request bug #45

Closed
0xAX opened this issue Nov 10, 2015 · 2 comments
Closed

send_remote_request bug #45

0xAX opened this issue Nov 10, 2015 · 2 comments

Comments

@0xAX
Copy link
Member

0xAX commented Nov 10, 2015

It seems that the eradius_client:send_remite_request_bug/4 function contains a bug. We are passing a radius_request to the send_remote_request_loop function as fifth parameter. For now this parameter can be plain radius_request or encoded request depends on the get_remote_version value:

Request2 = case eradius_node_mon:get_remote_version(Node) of
                           {0, Minor} when Minor < 6 ->
                               eradius_lib:encode_request(Request1);
                           _ ->
                               Request1
                       end,
SenderPid = spawn(Node, ?MODULE, send_remote_request_loop, [self(), Socket, ReqId, {IP, Port}, Request2, Options]),

which is end up will call send_request_loop/5. The problem that the send_request_loop/5 has clause only for non-encoded radius_request.

@liveforeverx
Copy link
Contributor

Check any version, which exists before 0.6.0, it was made to be compatible with older versions, which accepts only encoded radius request (it is done for example, that you can run 0.6.0 version with remote 0.4.0 eradius version, which have older codebase).

@liveforeverx
Copy link
Contributor

related pull request: #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants