Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up on config settings: Build sdist, then install via wheel, config settings no passed through #3125

Open
nschloe opened this issue Sep 15, 2023 · 2 comments
Assignees
Labels
enhancement help:wanted Issues that have been acknowledged, a solution determined and a PR might likely be accepted.

Comments

@nschloe
Copy link
Contributor

nschloe commented Sep 15, 2023

After helping to complete #3090 (thanks!), one can now pass config_settings to the build backends via, e.g.,

[testenv:.pkg]
config_settings_build_sdist =
  A = b
config_settings_build_wheel =
  X = y

I noticed though that when building sdists, the subsequent installation step

py3: install_package> python -I -m pip install --force-reinstall --no-deps /path/to/.tox/.tmp/package/1/foobar-1.0.0.tar.gz

again employs wheel building without the config settings being passed. They would have to be passed to to pip as --config-settings.

Would it be sensible to introduce another variable here, or should config_settings_build_wheel be used?

@gaborbernat
Copy link
Member

We don't want another variable. config_settings_build_wheel could be passed on as an env var here perhaps 🤔

@gaborbernat gaborbernat added the help:wanted Issues that have been acknowledged, a solution determined and a PR might likely be accepted. label Mar 5, 2024
@henryborchers
Copy link

Am I understanding this correctly? config_settings_build_wheel does NOT pass to install_package. is this a bug or by design?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help:wanted Issues that have been acknowledged, a solution determined and a PR might likely be accepted.
Projects
None yet
Development

No branches or pull requests

3 participants