-
-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to append overrides #2738
Comments
Appending only makes sense here because this is a list, but how would appending work for a boolean flag? 😆 I don't think you can generalize this 🤔 For what's worth the legacy https://tox.wiki/en/latest/cli_interface.html#tox-legacy---force-dep is what you likely want 😊 fixed by unreleased #2731; perhaps there's a case to make this part of the non-legacy endpoints 😊 |
Indeed, that wouldn't work and I am OK with that :-) I'm not suggesting that override should always append, but that there should be an option to append upon request. E.g.
|
That syntax is not supported by argparse, so supporting that sounds like you're asking a lot of heavy lifting 😅 |
I'm looking at what it would take to do this, and it looks like the current parse is done with So I'm wondering, could we do something as simple as checking for a key with check
|
This is all a parsing issue, the override being applied is already resolved. |
What's the problem this feature will solve?
--override
option is nice for changes, but currently it only replaces the config file option. But multiple options are list-like and it would be much better to have an option to append to the list without a need to copy the whole contents.Describe the solution you'd like
I'd like to have an option to provide additions to the config lists, such as
deps
,passenv
,setenv
, etc.Example
I'd like to add
ipdb
to the testenv to debug the problem liketox --override testenv.deps=ipdb run -e py310
, but it also drops all thedeps
from the testenv config and tests crashes completely unless I explicitly setdeps
to all currentdeps
and theipdb
.Also I'd like to be able to pass such option to user level config so I can have it in all testenvs.
Alternative Solutions
I have working plugin https://pypi.org/project/tox-ipdb-plugin/ for the tox3, but it seems it can almost be replaced only by a user config. And separate plugin would be needed if other changes would be needed.
The text was updated successfully, but these errors were encountered: