Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tox4: (regression) unable to run interactive commands #2374

Closed
ssbarnea opened this issue Mar 9, 2022 · 5 comments
Closed

tox4: (regression) unable to run interactive commands #2374

ssbarnea opened this issue Mar 9, 2022 · 5 comments
Labels
bug:normal affects many people or has quite an impact level:hard rought estimate that this might be quite hard to implement

Comments

@ssbarnea
Copy link
Member

ssbarnea commented Mar 9, 2022

While with tox 3 it was possible to start interactive commands as shells, with tox4 this is no longer possible because apparently there is some buffering implied which has two side effects:

  • Output not displayed until a new line is send, so login: prompt would not be seen
  • What you type is not displayed

I tried setting PYTHONUNBUFFERED=1 but it has no effect.

If you happened to had a tox env that runs docker run -it container-name /bin/bash, debugging would become close to impossible with tox4.

@ssbarnea ssbarnea added the bug:normal affects many people or has quite an impact label Mar 9, 2022
@gaborbernat gaborbernat added this to the 4.1 milestone Mar 9, 2022
@gaborbernat
Copy link
Member

PRs to address this are welcome, note though this likely is a very hard PR. I'll mark it not important enough though to block release. Furthermore, your report is missing many required information: OS and console manager you're using, for example, project. This should work (mostly) on Linux, I've tried with PDB/breakpoint, not sure how much docker differs. Might be related to #1773

@ssbarnea
Copy link
Member Author

ssbarnea commented Mar 9, 2022

I will try to narrow it down tomorrow. I wondered myself because I do remember being able to use pdb too, so it might not really be a general problem that breaks all interactive consoles.

tx

@jugmac00 jugmac00 added the level:hard rought estimate that this might be quite hard to implement label Jun 4, 2022
@masenf
Copy link
Collaborator

masenf commented Dec 14, 2022

this likely is a very hard PR

still a work in progress, but I think this PR will address this issue.

@ssbarnea
Copy link
Member Author

I think that the interactivity issue is not generalized because I think that pdb and ipdb are still working... or I need to double check. It would quite sad to not be able to do tox -e py -- -s --pdb.

@masenf
Copy link
Collaborator

masenf commented Jan 19, 2023

@ssbarnea this should be fixed on posix platforms as of tox 4.0.12 please try again and reopen if you still face issues running interactive commands.

For Windows specifically, we are tracking pty support with #2337, but likely not happening any time soon.

@masenf masenf closed this as completed Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:normal affects many people or has quite an impact level:hard rought estimate that this might be quite hard to implement
Projects
None yet
Development

No branches or pull requests

4 participants