-
-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support glob patterns and factors in 'depends' option #1152
Comments
Factors are supported (or anything that works within envlist that is). Patterns AFAIK not so much. In principle, I'm not against this. Could be non-trivial to implement it for the general case though. |
Handling of factors is probably not working, see MWE below.
and the output:
|
Ah, like that will not work. That actually is not the factor syntax, that's the mark syntax. Here's what I am referring to when I see factor support:
What you're implying there resembles more along the lines of environment markers:
That way on its own cannot work because what if there is also a test env. Does test refer to that one env, or all envs having the test factor? At best I could see something like |
According to tox documentation: The main problem we want to resolve is the need to copy sublists of environments. When new environment is added, but forgotten in |
Agreed is a gap, contributions are welcome, otherwise, hopefully, we'll get to this at some point. |
An implementation here might also be able to solve #318 at the same time. |
Currently, we do support factors and label based selection. Glob pattern could be added, perhaps would be under the |
Addition of parallel runs and dependencies is awesome, but we quite miss any support for factors or glob patterns in the
depends
option.In case we have several environments
we have to set dependencies for
compute-coverage
individuallywhich is error prone and not quite comfortable.
I suggest to allow glob patterns
and factors similarly to other parts of configuration.
I don't quite feel I would be able to provide a PR.
The text was updated successfully, but these errors were encountered: