Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not strip .0 version for compatible releases #30

Merged
merged 1 commit into from
Oct 3, 2020
Merged

Do not strip .0 version for compatible releases #30

merged 1 commit into from
Oct 3, 2020

Conversation

jugmac00
Copy link
Member

@jugmac00 jugmac00 commented Oct 3, 2020

... as the complete version number is important.

See PEP 440 for more details
( https://www.python.org/dev/peps/pep-0440/#compatible-release ).

Fixes #24

modified: src/tox_ini_fmt/formatter/requires.py
modified: tests/formatter/test_requires.py

... as the complete version number is important.

See PEP 440 for more details
( https://www.python.org/dev/peps/pep-0440/#compatible-release ).

Fixes #24

modified:   src/tox_ini_fmt/formatter/requires.py
modified:   tests/formatter/test_requires.py
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2020

Codecov Report

Merging #30 into main will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #30   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          247       247           
  Branches        55        55           
=========================================
  Hits           247       247           
Flag Coverage Δ
#tests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/tox_ini_fmt/formatter/requires.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b630270...082c071. Read the comment docs.

@jugmac00
Copy link
Member Author

jugmac00 commented Oct 3, 2020

As mentioned in #24 I have only taken care of the == and >= cases, e.g. not for the <= case.

It is too late to think this problem through :-)

@gaborbernat gaborbernat merged commit d769457 into tox-dev:main Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trailing zeros are stripped from versions
3 participants