Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of spaces for indentation #26

Closed
jugmac00 opened this issue Oct 3, 2020 · 2 comments
Closed

Number of spaces for indentation #26

jugmac00 opened this issue Oct 3, 2020 · 2 comments

Comments

@jugmac00
Copy link
Member

jugmac00 commented Oct 3, 2020

Hi,

I just tried this new tool, and it works great, and I like the output a lot.

I am curious why you decided to go with 2 spaces for indentation.

Pretty much all of my own projects, the projects I contribute to (zope, plone, ...) or I use e.g. tox, pytest, flask, ... use 4 spaces for indentation in config files, especially for tox.ini.

As a Python developer, this is something we are used to, but imho the better reason is, that the ini file then is way easier to scan, as there is a bigger distinction between keys and values ( This is similar to when you have a text and you make the heading not just one font size bigger, but some more).

Do you plan to make the number of spaces configurable?

Thanks!

@gaborbernat
Copy link
Member

I went for the two space to save some screen real estate, that being said this project wants to compliment setup-cfg-fmt, and that uses 4 spaces, so we should probably also use 4 spaces, now that I think about it.

@jugmac00
Copy link
Member Author

jugmac00 commented Oct 3, 2020

Great news!

Well, I spent some time on my smartphone reading the source how to figure out how to implement a command line flag to make this optional, but directly using an indentation of 4 would be even better :-)

Just in case, I created #28 - no pressure :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants