Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High CPU usage and general unresponsiveness #275

Open
joeltimothyoh opened this issue Aug 27, 2021 · 3 comments
Open

High CPU usage and general unresponsiveness #275

joeltimothyoh opened this issue Aug 27, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@joeltimothyoh
Copy link
Member

joeltimothyoh commented Aug 27, 2021

Issue

High CPU usage and general unresponsiveness.

Expectation

Minimal CPU usage and smooth gameplay.

Discussion

One of the recent versions since the closure of #265 appears to have introduced high CPU usage and general unresponsiveness of the application. The delay is bad enough that not even a comfortable typing speed can be achieved.

@leojonathanoh
Copy link
Member

Related #251

@leojonathanoh leojonathanoh self-assigned this Aug 27, 2021
@leojonathanoh leojonathanoh added the enhancement New feature or request label Aug 27, 2021
@leojonathanoh
Copy link
Member

In general, #251 relates to rendering the speech only that applies to all modes.

However, addition to #251 impact, performance degradation is also due response validation. In perfection mode, where no amends are allowed, only the current character of the Student response is validated against the Trainer's truth, so there is no impact to performance. In contrast, when perfection is turned off, each and every character in the Student response is validated against the Trainer's truth. @joeltimothyoh

@leojonathanoh
Copy link
Member

leojonathanoh commented Aug 30, 2021

@joeltimothyoh perhaps, perfection can be turned on by default. I actually think that is better. Amends is generally a less effective way of practising because the Student focuses on corrections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants