Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package.json): build script #129

Merged
merged 2 commits into from
Jul 8, 2024
Merged

fix(package.json): build script #129

merged 2 commits into from
Jul 8, 2024

Conversation

po4tion
Copy link
Contributor

@po4tion po4tion commented Jul 6, 2024

When I run the "yarn build" command, I get the following error. I think it's a matter of executive authority. Rather than setting the executive authority separately, I solved it by adding the "sh" command.

image

@po4tion po4tion requested a review from raon0211 as a code owner July 6, 2024 15:46
Copy link

vercel bot commented Jul 6, 2024

@po4tion is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a2e42b8) to head (bc064b4).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #129   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           66        68    +2     
  Lines          371       384   +13     
  Branches        48        49    +1     
=========================================
+ Hits           371       384   +13     

@raon0211
Copy link
Collaborator

raon0211 commented Jul 8, 2024

I guess this is because we don't have shebangs in the first line of postbuild.sh. Why not add it instead, like:

#!/bin/sh

echo ...

@po4tion
Copy link
Contributor Author

po4tion commented Jul 8, 2024

@raon0211 I added "shebangs" and it works fine! Thank you! fix: add shebangs

Copy link
Collaborator

@raon0211 raon0211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@raon0211 raon0211 merged commit 2ce004c into toss:main Jul 8, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants