Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(without): Add without function #115

Merged
merged 8 commits into from
Jul 3, 2024
Merged

Conversation

iDevGon
Copy link
Contributor

@iDevGon iDevGon commented Jul 2, 2024

Closes #106

This pull request implements the without function, which behaves similarly to the without function in lodash.

The function takes an array and a list of values as parameters and uses the SameValueZero equality comparison for equality comparisons.

Below is a benchmark comparing our without function to lodash's without.

Screenshot 2024-07-03 at 12 04 01 AM

@iDevGon iDevGon requested a review from raon0211 as a code owner July 2, 2024 15:22
Copy link

vercel bot commented Jul 2, 2024

@GonhongCheon is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ead6a82) to head (66fd67a).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #115   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           58        60    +2     
  Lines          314       323    +9     
  Branches        37        38    +1     
=========================================
+ Hits           314       323    +9     

src/array/without.ts Outdated Show resolved Hide resolved
src/array/without.ts Outdated Show resolved Hide resolved
src/array/without.ts Outdated Show resolved Hide resolved
src/array/without.ts Outdated Show resolved Hide resolved
src/array/without.ts Outdated Show resolved Hide resolved
src/array/without.spec.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@raon0211 raon0211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your great contribution!

@raon0211 raon0211 merged commit a82eb93 into toss:main Jul 3, 2024
7 of 8 checks passed
Copy link

codspeed-hq bot commented Jul 3, 2024

CodSpeed Performance Report

Merging #115 will degrade performances by 64.39%

Comparing GonhongCheon:feat/without (66fd67a) with GonhongCheon:feat/without (85a0ed6)

Summary

⚡ 12 improvements
❌ 6 regressions
✅ 92 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark GonhongCheon:feat/without GonhongCheon:feat/without Change
lodash 206.5 µs 49.2 µs ×4.2
lodash/difference 226.8 µs 56.7 µs ×4
lodash/differenceBy 224.8 µs 70.9 µs ×3.2
lodash/differenceWith 224.6 µs 69.3 µs ×3.2
lodash/intersectionBy 435.8 µs 322.1 µs +35.3%
lodash/intersectionWith 246.6 µs 92.3 µs ×2.7
lodash/isNil 206.4 µs 35.3 µs ×5.8
lodash/keyBy 215.7 µs 58.9 µs ×3.7
lodash/pick 377.7 µs 86.6 µs ×4.4
es-toolkit/range 39.3 µs 48.3 µs -18.71%
lodash/range 33.5 µs 44.1 µs -23.95%
lodash/shuffle 198.8 µs 316 µs -37.1%
lodash/union 239.9 µs 75.8 µs ×3.2
lodash/unionBy 354.7 µs 75.6 µs ×4.7
lodash/unionWith 85.1 µs 238.9 µs -64.39%
lodash/xor 242.4 µs 377.5 µs -35.78%
lodash/xorBy 91.3 µs 251.3 µs -63.68%
lodash/xorWith 260.2 µs 111.4 µs ×2.3

@iDevGon iDevGon deleted the feat/without branch September 5, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for without
3 participants