Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update installation section #102

Merged
merged 2 commits into from
Jun 30, 2024

Conversation

minsoo-web
Copy link
Member

@minsoo-web minsoo-web commented Jun 30, 2024

I update installation section with vitepress api

  • combine npm, yarn, pnpm command with code-group API

preview

image

Copy link

vercel bot commented Jun 30, 2024

@minsoo-web is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (02f14b3) to head (7edcdb2).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #102   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           57        57           
  Lines          311       311           
  Branches        37        37           
=========================================
  Hits           311       311           

Copy link

codspeed-hq bot commented Jun 30, 2024

CodSpeed Performance Report

Merging #102 will degrade performances by 81.21%

Comparing minsoo-web:docs/install-section (7edcdb2) with main (02f14b3)

Summary

⚡ 2 improvements
❌ 5 regressions
✅ 91 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main minsoo-web:docs/install-section Change
lodash 343 µs 49.3 µs ×7
lodash/intersectionBy 319.4 µs 495.9 µs -35.59%
lodash/isNil 35.7 µs 190.2 µs -81.21%
lodash/union 75.8 µs 353.5 µs -78.55%
lodash/unionBy 75.7 µs 229.3 µs -67.01%
es-toolkit/uniqBy 14.8 ms 13.1 ms +12.36%
lodash/zip 242.4 µs 360 µs -32.68%

Copy link
Collaborator

@raon0211 raon0211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@raon0211 raon0211 merged commit e62c061 into toss:main Jun 30, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants