From f2b7cd9d15f1deebd36c17bf2924f4abfe20467b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gromit=20=28=EC=A0=84=EB=AF=BC=EC=9E=AC=29?= <64779472+ssi02014@users.noreply.github.com> Date: Thu, 25 Apr 2024 19:00:21 +0900 Subject: [PATCH] =?UTF-8?q?=08fix:=20convertQwertyToHangul=20split=20?= =?UTF-8?q?=EB=B0=8F=20Non-null=20assertion=20operator=20=EC=A0=9C?= =?UTF-8?q?=EA=B1=B0,=20=EB=84=A4=EC=9D=B4=EB=B0=8D=20=EC=98=A4=ED=83=80?= =?UTF-8?q?=20=EC=88=98=EC=A0=95=20(#75)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * refac: convertQwertyToHangul split 및 Non-null assertion operator 제거, 네이밍 오타 수정 * Create young-bears-double.md --------- Co-authored-by: 박찬혁 --- .changeset/young-bears-double.md | 5 +++++ src/convertQwertyToHangulAlphabet.ts | 2 +- src/disassembleCompleteHangulCharacter.ts | 6 +++--- src/removeLastHangulCharacter.ts | 6 +++--- 4 files changed, 12 insertions(+), 7 deletions(-) create mode 100644 .changeset/young-bears-double.md diff --git a/.changeset/young-bears-double.md b/.changeset/young-bears-double.md new file mode 100644 index 00000000..291c0a2c --- /dev/null +++ b/.changeset/young-bears-double.md @@ -0,0 +1,5 @@ +--- +"es-hangle": patch +--- + +refac: convertQwertyToHangul split 및 Non-null assertion operator 제거, 네이밍 오타 수정 diff --git a/src/convertQwertyToHangulAlphabet.ts b/src/convertQwertyToHangulAlphabet.ts index f172ed35..bcc4aa81 100644 --- a/src/convertQwertyToHangulAlphabet.ts +++ b/src/convertQwertyToHangulAlphabet.ts @@ -27,5 +27,5 @@ export function convertQwertyToHangul(word: string): string { if (!word) { return ''; } - return assembleHangul([...convertQwertyToHangulAlphabet(word).split('')]); + return assembleHangul([...convertQwertyToHangulAlphabet(word)]); } diff --git a/src/disassembleCompleteHangulCharacter.ts b/src/disassembleCompleteHangulCharacter.ts index 36220bbd..3cb5c7a5 100644 --- a/src/disassembleCompleteHangulCharacter.ts +++ b/src/disassembleCompleteHangulCharacter.ts @@ -32,8 +32,8 @@ export function disassembleCompleteHangulCharacter( const firstIndex = Math.floor((hangulCode - lastIndex) / NUMBER_OF_JONGSUNG / NUMBER_OF_JUNGSUNG); return { - first: HANGUL_CHARACTERS_BY_FIRST_INDEX[firstIndex]!, - middle: HANGUL_CHARACTERS_BY_MIDDLE_INDEX[middleIndex]!, - last: HANGUL_CHARACTERS_BY_LAST_INDEX[lastIndex]!, + first: HANGUL_CHARACTERS_BY_FIRST_INDEX[firstIndex], + middle: HANGUL_CHARACTERS_BY_MIDDLE_INDEX[middleIndex], + last: HANGUL_CHARACTERS_BY_LAST_INDEX[lastIndex], } as const; } diff --git a/src/removeLastHangulCharacter.ts b/src/removeLastHangulCharacter.ts index 6d4f0034..944fc331 100644 --- a/src/removeLastHangulCharacter.ts +++ b/src/removeLastHangulCharacter.ts @@ -18,14 +18,14 @@ import { excludeLastElement } from './_internal'; * removeLastHangulCharacter('일요일') // 일요이 */ export function removeLastHangulCharacter(words: string) { - const disassembedGroups = disassembleHangulToGroups(words); - const lastCharacter = disassembedGroups.at(-1); + const disassembledGroups = disassembleHangulToGroups(words); + const lastCharacter = disassembledGroups.at(-1); if (lastCharacter == null) { return ''; } - const withoutLastCharacter = disassembedGroups + const withoutLastCharacter = disassembledGroups .filter(v => v !== lastCharacter) .map(([first, middle, last]) => { if (middle != null) {