Fix for issue #517: torch.all #534
Merged
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| TENSOR_IMPLEMENT_LOGICAL_SUM(logicalall, &=, 1) | ||
| TENSOR_IMPLEMENT_LOGICAL_SUM(logicalany, |=, 0) |
There was a problem hiding this comment.
Is it not sufficient to change &= to && and |= to || here? This would use the correct logical operators rather than bitwise operators. sum would probably need to be a bool in this case.
|
I am not sure I understand your suggestion. &= and |= assign to the left operand. && and || do not. |
|
After discussing with Tim that there is no hidden magic in using |= instead of logical ||, changing macros and operators to sum = sum OP ... and && and || |
|
squash your commits and this is good to merge. thnx |
torch.all only returns true if all numbers in the tensor are odd torch#517 Update THTensorMath.c Respective test
|
Done |
|
@ivpopov still dont see a squash. did you force-push back to the same PR? |
|
Thanks! |
colesbury
pushed a commit
to colesbury/torch7
that referenced
this pull request
Nov 3, 2016
Fix for issue torch#517: torch.all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for "torch.all only returns true if all numbers in the tensor are odd #517"