-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows mswin build - failing #41
Comments
I didn't mention that I'm not really a c type, so I'm not comfortable trying to fix this on the c side. I could submit a PR forcing mswin platform to run in 'pure ruby' mode? |
I implemented a fix in #43 (and found this issue afterwards) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Although most people using Ruby on Windows use MSYS2/MinGW builds, ruby/ruby has been testing on mswin (msvc) builds for quite a while. The build does pass all tests, so all the extension stdlib/default gems included with Ruby compile.
While trying to compile Puma with it, Puma uses RuboCop in CI, and it wouldn't compile jaro_winkler when running
bundle install
. Below is the log. I ran this locally, so happy to test anything. Using VS 2019. FYI, Puma compiled on mswin with OpenSSL.Note: Puma has been running CI against Ruby Windows MSYS2/MinGW builds for quite while with no problem (compiling jaro_winkler or Puma). MSYS2 is using gcc 9.2.0.
The text was updated successfully, but these errors were encountered: