Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

noscript is not used in react 15 #64

Closed
piranha opened this issue Apr 27, 2016 · 0 comments
Closed

noscript is not used in react 15 #64

piranha opened this issue Apr 27, 2016 · 0 comments

Comments

@piranha
Copy link
Collaborator

piranha commented Apr 27, 2016

Right now Rum returns [:noscript] on server when there is no DOM generated.

What it needs to return is a comment like <!--react-empty: %d-->, where %d is a data-reactid (number from the same list of numbers, also taken by sequence).

I'm not exactly sure what's the best way to implement that...
@tonsky tonsky closed this as completed in b772a5e May 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@piranha