Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all fields of Context private, accessible through getters? #56

Open
strohel opened this issue May 20, 2021 · 0 comments
Open

Make all fields of Context private, accessible through getters? #56

strohel opened this issue May 20, 2021 · 0 comments

Comments

@strohel
Copy link
Member

strohel commented May 20, 2021 •
edited
Loading

Mentioned by @skywhale in #53 (comment) CC @bschwind.

It would be certainly more locally consistent as the receive_timeout field is already private on purpose. It would cause some churn for crate users, but better sooner than later?

Note that Context is no longer user-constructible after merging #53.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@strohel