Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pt-BR language #78

Merged
merged 4 commits into from
Oct 21, 2022

Conversation

rayanneblima
Copy link
Contributor

Checklist

Please put "X" in the below checkboxes that apply::

  • If committing a bugfix, I have tested it in different browsers (Chrome, Firefox, Safari).
  • If committing a new feature, I have first submitted an issue (Please note: you are free to open PRs for non-issued features, but opening an issue increases your chance of a successful PR).
  • If committing a new feature, I have also written an appropriate test suite for it.

I have tested the following:

  • Qalendar component in month mode.
  • Qalendar component in week mode.
  • Qalendar component in day mode.
  • All of the above modes on emulated mobile view.
  • Dragging and dropping events.
  • Resizing events in day/week modes.
  • Clicking events to open event dialog.

This PR solves the following problem**.

1- Run project:

yarn dev

2- Choose 'pt-BR' language in DevToolbar;

3- The button to change the calendar view will be in brazilian portuguese:

image

@tomosterlund
Copy link
Owner

tomosterlund commented Oct 20, 2022

@rayanneblima do you know if the language keys you added, also would work out for Portuguese spoken in Portugal? In that case you could change if (locale.includes("BR")) locale = "pt-BR"; to if (locale.startsWith("pt")) locale = "pt-BR"; in order to use these keys for all Portuguese. If however it's specific to Brazilian Portuguese, the line would have to be:
if (locale === 'pt-BR') locale = "pt-BR";

@rayanneblima
Copy link
Contributor Author

@rayanneblima do you know if the language keys you added, also would work out for Portuguese spoken in Portugal? In that case you could change if (locale.includes("BR")) locale = "pt-BR"; to if (locale.startsWith("pt")) locale = "pt-BR"; in order to use these keys for all Portuguese. If however it's specific to Brazilian Portuguese, the line would have to be: if (locale === 'pt-BR') locale = "pt-BR";

Apparently, in this case, it's the same keys. I will make the changes.

@tomosterlund tomosterlund merged commit 2d04415 into tomosterlund:master Oct 21, 2022
@felix-berlin
Copy link
Collaborator

🎉 This PR is included in version 1.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants