Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong interfaces info due to compiler optimization #5

Open
tomer8007 opened this issue Sep 7, 2021 · 1 comment
Open

Wrong interfaces info due to compiler optimization #5

tomer8007 opened this issue Sep 7, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@tomer8007
Copy link
Owner

image

Above methods should actually be CompositorFrameSinkClient.OnBeginFrame and CompositorFrameSink.SubmitCompositorFrame.
Apparently it's happening because now clang may group similar globals together in the same file:

image
which breaks the way MojoMethodHashesExtractor works.
@tomer8007 tomer8007 added the bug Something isn't working label Sep 7, 2021
@tomer8007
Copy link
Owner Author

This is something that's now slightly better thanks to an algorithm in FindValidationInfoForInterfaceName. Still far from detecting all names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomer8007