Merge pull request davidjerleke#751 from davidjerleke/bug/davidjerlek…

…e#750 [Bug]: Autoplay and AutoScroll not destroyed properly
tomascf · Feb 20, 2024 · 0926b15 · 0926b15
2 parents b04f0af + 44cc2ca
commit 0926b15
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/embla-carousel-auto-scroll/src/components/AutoScroll.ts b/packages/embla-carousel-auto-scroll/src/components/AutoScroll.ts
@@ -99,15 +99,15 @@ function AutoScroll(userOptions: AutoScrollOptionsType = {}): AutoScrollType {
  }
 
  function destroy(): void {
- destroyed = true
- playing = false
  emblaApi
  .off('init', startScroll)
  .off('reInit', startScroll)
  .off('pointerDown', stopScroll)
  .off('pointerUp', startScrollOnSettle)
  .off('settle', onSettle)
  stopScroll()
+ destroyed = true
+ playing = false
  }
 
  function startScroll(): void {

diff --git a/packages/embla-carousel-autoplay/src/components/Autoplay.ts b/packages/embla-carousel-autoplay/src/components/Autoplay.ts
@@ -95,8 +95,6 @@ function Autoplay(userOptions: AutoplayOptionsType = {}): AutoplayType {
  }
 
  function destroy(): void {
- destroyed = true
- playing = false
  emblaApi
  .off('init', startTimer)
  .off('reInit', startTimer)
@@ -105,6 +103,8 @@ function Autoplay(userOptions: AutoplayOptionsType = {}): AutoplayType {
  stopTimer()
  cancelAnimationFrame(animationFrame)
  animationFrame = 0
+ destroyed = true
+ playing = false
  }
 
  function startTimer(): void {