Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link underlines not showing on chrome #51

Closed
mkhezr opened this issue Aug 23, 2018 · 2 comments
Closed

link underlines not showing on chrome #51

mkhezr opened this issue Aug 23, 2018 · 2 comments

Comments

@mkhezr
Copy link

mkhezr commented Aug 23, 2018

Hi Toma,

I am using your theme for my website which I'm hosting on github pages. When viewing the website locally I can see the link underlines which I understand is created using a combination of a background image and text shadow. The strange thing is that the underlines do not show up on chrome when I view the online version of my website. They show fine on Safari and on my iphone. They also show fine when I view my website on chrome locally.

If you visit "Future of Work" post on my website for example and search for "Whitebox Consulting", that should be a link. If you hover over it, it'll get highlighted. But the underline should not show up if you are viewing on chrome. I'm using the most recent version of chorme : 68.0.3440.106

So I started inspecting and figured out that if I change the .content a css and instead of background-size: 1px 2px I set it to background-size: 2px 3px then the underline starts showing up! It seems like the image has been too small and 1 pixel has been lost somewhere.

Do you have any idea why this is happening?

@mkhezr
Copy link
Author

mkhezr commented Aug 27, 2018

I figured that the underline was not showing because the page was zoomed out to 90%.

@mkhezr mkhezr closed this as completed Aug 27, 2018
@tomanistor
Copy link
Owner

Hey @mkhezr, thanks for figuring that out!

I thought the issue might have been related to Chrome, which recently implemented a style change with underlined words. Since Chrome 64, the browser creates the same "ink skipping" effect by default as I have done with the links of this themes. https://superuser.com/questions/1293529/when-did-chrome-start-underlining-links-differently

I've noticed that this may sometimes mess with the theme's link underlines on Chrome at different resolutions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants